feat(pstate): opt in changes and sooooo

hosts/kima/modules.nix

@@ -5,6 +5,7 @@
         variant = "latest";
         hardware = [ "amd" ];
         extraKernelParams = [ ];
+        amdOverdrive.enable = true;
       };
       loader = {
         default = {

modules/nixos/boot/kernel/default.nix

@@ -5,7 +5,12 @@
   ...
 }:
 let
-  inherit (lib) mkOption types;
+  inherit (lib)
+    mkOption
+    types
+    mkEnableOption
+    mkIf
+    ;
   cfg = config.nixos.boot.kernel;
 
   hasHardware = hw: builtins.elem hw cfg.hardware;
@@ -37,8 +42,11 @@ in
         );
         default = [ ];
         description = "List of hardware types (e.g. GPU and CPU vendors) to configure kernel settings for.";
+
       };
 
+      amdOverdrive.enable = mkEnableOption "Enable AMD pstate/overdrive";
+
       extraKernelParams = mkOption {
         type = types.listOf types.str;
         default = [ ];
@@ -74,7 +82,7 @@ in
         "quiet"
         "splash"
       ]
-      ++ (if hasHardware "amd" then [ "amd_pstate=active" ] else [ ])
+      ++ (if hasHardware "amd" then [ ] else [ ])
       ++ (if hasHardware "intel" then [ ] else [ ])
       ++ (if hasHardware "nvidia" then [ ] else [ ])
       ++ cfg.extraKernelParams;
@@ -85,5 +93,6 @@ in
         ++ (if hasHardware "nvidia" then [ "nouveau" ] else [ ])
         ++ cfg.extraBlacklistedModules;
     };
+    hardware.amdgpu.overdrive.enable = mkIf cfg.amdOverdrive.enable true;
   };
 }

modules/nixos/hardware/graphics/default.nix

@@ -89,37 +89,39 @@ in
 
   config = mkIf cfg.enable (mkMerge [
     {
-      hardware.graphics = {
+      hardware = {
-        enable = true;
+        graphics = {
-        enable32Bit = true;
+          enable = true;
-        extraPackages = flatten (
+          enable32Bit = true;
-          concatMap (
+          extraPackages = flatten (
-            vendor:
+            concatMap (
-            if vendor == "amd" then
+              vendor:
-              commonPackages ++ mesaVulkanPackages
+              if vendor == "amd" then
-            else if vendor == "intel" then
+                commonPackages ++ mesaVulkanPackages
-              commonPackages
+              else if vendor == "intel" then
-              ++ mesaVulkanPackages
+                commonPackages
-              ++ (with pkgs; [
+                ++ mesaVulkanPackages
-                vpl-gpu-rt
+                ++ (with pkgs; [
-                intel-media-driver
+                  vpl-gpu-rt
-                intel-compute-runtime
+                  intel-media-driver
-                intel-vaapi-driver
+                  intel-compute-runtime
-              ])
+                  intel-vaapi-driver
-            else if vendor == "nvidia" then
+                ])
-              commonPackages
+              else if vendor == "nvidia" then
-              ++ (with pkgs; [
+                commonPackages
-                nvidiaOffloadScript
+                ++ (with pkgs; [
-                intel-media-driver
+                  nvidiaOffloadScript
-                nvidia-vaapi-driver
+                  intel-media-driver
-                vulkan-tools
+                  nvidia-vaapi-driver
-              ])
+                  vulkan-tools
-            else
+                ])
-              [ ]
+              else
-          ) cfg.vendors
+                [ ]
-        );
+            ) cfg.vendors
+          );
 
-        extraPackages32 = flatten (concatMap (_: commonPackages32) cfg.vendors);
+          extraPackages32 = flatten (concatMap (_: commonPackages32) cfg.vendors);
+        };
       };
 
       environment.systemPackages = flatten (
@@ -145,10 +147,6 @@ in
       );
     }
 
-    (mkIf (hasVendor "amd") {
-      hardware.amdgpu.overdrive.enable = true;
-    })
-
     (mkIf (hasVendor "nvidia") {
       hardware.nvidia = {
         package =

users/cnst/modules/kimamod.nix

@@ -132,7 +132,7 @@
         enable = true;
       };
       syncthing = {
-        enable = true;
+        enable = false;
       };
       udiskie = {
         enable = true;